Skip to content

Comments

fix: Modernize build system to use vite and @nextcloud/vue version 8#517

Merged
susnux merged 1 commit intomasterfrom
update/nextcloud-libs
Mar 14, 2024
Merged

fix: Modernize build system to use vite and @nextcloud/vue version 8#517
susnux merged 1 commit intomasterfrom
update/nextcloud-libs

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 12, 2023

  1. Update @nextcloud/vue and @nextcloud/dialogs
  2. Migrate to vite instead of webpack, otherwise the assets are ridiculously big (webpack fails tree shaking and results in 2.6MiB assets just for settings...).

@nickvergessen nickvergessen removed their request for review November 12, 2023 08:08
@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@blizzz
Copy link
Member

blizzz commented Nov 23, 2023

Please don't forget to set the milestone when opening a PR 😃

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

This was referenced Mar 12, 2024
Merged
Merged
@susnux susnux requested review from ShGKme and skjnldsv and removed request for jotoeri March 14, 2024 10:15
@susnux susnux force-pushed the update/nextcloud-libs branch from e2608da to 34cd51d Compare March 14, 2024 10:20
@susnux susnux requested a review from schiessle March 14, 2024 10:20
@susnux susnux merged commit 72f6972 into master Mar 14, 2024
@susnux susnux deleted the update/nextcloud-libs branch March 14, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@datenangebot datenangebot Awaiting requested review from datenangebot

@ShGKme ShGKme Awaiting requested review from ShGKme

@schiessle schiessle Awaiting requested review from schiessle

Assignees

No one assigned

Labels

3. to review feedback-requested

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux @blizzz @skjnldsv