Skip to content

add: Android 13 themed icon#170

Closed
sadorowo wants to merge 5 commits intonextcloud:masterfrom
sadorowo:master
Closed

add: Android 13 themed icon#170
sadorowo wants to merge 5 commits intonextcloud:masterfrom
sadorowo:master

Conversation

@sadorowo
Copy link
Contributor

@sadorowo sadorowo commented Jun 9, 2024

Fixes #169

Previews:

non-themed themed
image image

How to enable themed icon:

Warning

These instructions are for AOSP-based ROMs only.

  1. Ensure you are on Android 13 or higher.
  2. Long hold empty space on your home screen and select 'Wallpapers & style'.
  3. Scroll down and enable 'Themed icons':
    image

sadorowo added 2 commits June 9, 2024 13:52
@sadorowo
add: Android 13 themed icon
e693599 
Signed-off-by: sadorowo <[email protected]>
@sadorowo
add: resources
b66b0df 
Signed-off-by: sadorowo <[email protected]>
@binsky08 binsky08 added this to the v1.5.1 milestone Jun 9, 2024
@binsky08 binsky08 self-requested a review October 17, 2024 16:15
binsky08
binsky08 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@binsky08 binsky08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the pull requests. It looks good in general.

Adaptive icons are only supported from api level 26. Since passman-android currently also supports devices from api level 21, it still needs the legacy icon as a fallback.

I've the commits already locally, but I'm not allowed to edit this pr. So may I'll add them later or so. It's fine for now.

@sadorowo
Copy link
Contributor Author

sadorowo commented Jan 18, 2025

Hi, thanks for the pull requests. It looks good in general.

Adaptive icons are only supported from api level 26. Since passman-android currently also supports devices from api level 21, it still needs the legacy icon as a fallback.

I've the commits already locally, but I'm not allowed to edit this pr. So may I'll add them later or so. It's fine for now.

Screenshot_20250118-214933

weird, maintainers can edit PRs

@binsky08
Copy link
Collaborator

binsky08 commented Jan 18, 2025 •
edited
Loading

Hi, thanks for the pull requests. It looks good in general.
Adaptive icons are only supported from api level 26. Since passman-android currently also supports devices from api level 21, it still needs the legacy icon as a fallback.
I've the commits already locally, but I'm not allowed to edit this pr. So may I'll add them later or so. It's fine for now.

Screenshot_20250118-214933

weird, maintainers can edit PRs

yes, but I think I don't have the maintainer role

or I just failed somehow :D

@sadorowo
Copy link
Contributor Author

sadorowo commented Jan 19, 2025

Hi, thanks for the pull requests. It looks good in general.
Adaptive icons are only supported from api level 26. Since passman-android currently also supports devices from api level 21, it still needs the legacy icon as a fallback.
I've the commits already locally, but I'm not allowed to edit this pr. So may I'll add them later or so. It's fine for now.

Screenshot_20250118-214933
weird, maintainers can edit PRs

yes, but I think I don't have the maintainer role

or I just failed somehow :D

i've added you as a collaborator on my fork

@sadorowo sadorowo closed this by deleting the head repository May 26, 2025
@binsky08 binsky08 mentioned this pull request May 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@binsky08 binsky08 binsky08 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.6.0

Development

Successfully merging this pull request may close these issues.

Add themed icon

2 participants

@sadorowo @binsky08