Use square bracket syntax to modify array#797
Merged
binsky08 merged 1 commit intonextcloud:masterfrom Jul 16, 2023
Merged
Conversation
Signed-off-by: Hamid Dehnavi <[email protected]>
binsky08
approved these changes
Jul 6, 2023
Contributor
Author
|
@animalillo Shall i need to do anything else to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
square bracket syntax is used instead of the array_push method, if we want to add one element to the array, it's better to use $array[] = because in that way there is no overhead of calling a function.