use PHP8's constructor property promotion#793
Merged
binsky08 merged 2 commits intonextcloud:masterfrom Jul 16, 2023
Merged
Conversation
Signed-off-by: Hamid Dehnavi <[email protected]>
binsky08
reviewed
Jul 5, 2023
binsky08
reviewed
Jul 5, 2023
binsky08
reviewed
Jul 5, 2023
binsky08
reviewed
Jul 5, 2023
binsky08
reviewed
Jul 5, 2023
Co-authored-by: binsky <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
Contributor
Author
|
@binsky08 The Scrutinizer shows a time-out warning, shall I do anything else? |
Collaborator
The problem isn't you :D |
animalillo
approved these changes
Jul 16, 2023
Collaborator
|
Thanks for the pr! Code definitely looks better and now we don't need backwards compatibility with older php versions, so ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All class fields, constructor definition, and variable assignments are updated using constructor property promotion