fix icon service for absolute base hrefs without server part#785
Merged
binsky08 merged 2 commits intonextcloud:masterfrom Jun 25, 2023
Merged
fix icon service for absolute base hrefs without server part#785binsky08 merged 2 commits intonextcloud:masterfrom
binsky08 merged 2 commits intonextcloud:masterfrom
Conversation
HolgerHees
force-pushed
the
fix_icon_service
branch
from
a52fcfd to
843517d
Compare
binsky08
requested changes
Jun 19, 2023
Collaborator
binsky08
left a comment
binsky08
left a comment
There was a problem hiding this comment.
code looks good
thanks for the pr :)
Signed-off-by: Holger Hees <[email protected]>
Signed-off-by: Holger Hees <[email protected]>
HolgerHees
force-pushed
the
fix_icon_service
branch
from
7ffcab4 to
f514ce3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the scenario where an base href part is a absolute url but without a scheme and a domain part. In this case we should fall back to the scheme and domain part from the page itself.