Skip to content

fixed scrutinizer ci#784

Merged
binsky08 merged 1 commit intonextcloud:masterfrom
HolgerHees:fix_scrutinizer
Jun 25, 2023
Merged

fixed scrutinizer ci#784
binsky08 merged 1 commit intonextcloud:masterfrom
HolgerHees:fix_scrutinizer

Conversation

@HolgerHees
Copy link
Contributor

fix broken ci test by removing duplicate key "external_code_coverage"

Signed-off-by: Holger Hees <[email protected]>
@HolgerHees HolgerHees requested a review from binsky08 June 19, 2023 11:58
@HolgerHees HolgerHees added the bug label Jun 19, 2023
@HolgerHees HolgerHees requested a review from brantje June 19, 2023 11:59
Copy link
Collaborator

@binsky08 binsky08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no experience with scrutinizer, so I'm not sure if that fixes the check.

But regardless of that, the double entry is actually wrong (https://scrutinizer-ci.com/docs/tools/external-code-coverage/) and should be fixed

@binsky08 binsky08 added this to the 2.4.6 milestone Jun 19, 2023
@binsky08 binsky08 merged commit 19c6c3b into nextcloud:master Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants