Fix Postgres sharing issue #581#778
Merged
binsky08 merged 1 commit intonextcloud:masterfrom Jun 25, 2023
Merged
Conversation
fflorent
force-pushed
the
issue-581-fix-postgres-sharing
branch
2 times, most recently
from
ede3647 to
88564a6
Compare
Signed-off-by: Florent F <[email protected]>
fflorent
force-pushed
the
issue-581-fix-postgres-sharing
branch
from
88564a6 to
3cfb3bd
Compare
Collaborator
|
I'm not sure if the grouping by user might have served an important purpose (on multi user instances). |
binsky08
approved these changes
Jun 24, 2023
Collaborator
binsky08
left a comment
binsky08
left a comment
There was a problem hiding this comment.
it seems that grouping it not required for the functionality of that call
didn't find any issues with that during my short tests
thanks for the pr :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By removing the useless
group by, we fix issue #581The bug
Prerequesite:
Steps to reproduce using:
→ the sharing table is not displayed!
issue-581.webm
What is expected
issue-581-fixed.webm