App sync error until files app gets unlocked #653
Description
When I open the Notes app and it attempts to sync, sometimes it never finishes and just shows the circular refresh animation indefinitely. I can sync if I open the Nextcloud app first, ensure it's logged in (using biometric authentication) and then open the notes app. It seems to work until the Nextcloud app gets killed at some point during the day:
114 12-27 07:04:53.493 2145 2185 E AndroidRuntime: FATAL EXCEPTION: AsyncTask #1
115 12-27 07:04:53.493 2145 2185 E AndroidRuntime: Process: it.niedermann.owncloud.notes, PID: 2145
116 12-27 07:04:53.493 2145 2185 E AndroidRuntime: java.lang.RuntimeException: An error occurred while executing doInBackground()
117 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at android.os.AsyncTask$4.done(AsyncTask.java:399)
118 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:383)
119 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at java.util.concurrent.FutureTask.setException(FutureTask.java:252)
120 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at java.util.concurrent.FutureTask.run(FutureTask.java:271)
121 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:289)
122 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
123 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
124 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at java.lang.Thread.run(Thread.java:919)
125 12-27 07:04:53.493 2145 2185 E AndroidRuntime: Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.length()' on a null object reference
126 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at org.json.JSONTokener.nextCleanInternal(JSONTokener.java:121)
127 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at org.json.JSONTokener.nextValue(JSONTokener.java:98)
128 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at org.json.JSONArray.<init>(JSONArray.java:94)
129 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at org.json.JSONArray.<init>(JSONArray.java:110)
130 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at it.niedermann.owncloud.notes.util.ServerResponse$NotesResponse.getNotes(ServerResponse.java:37)
131 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at it.niedermann.owncloud.notes.persistence.NoteServerSyncHelper$SyncTask.pullRemoteChanges(NoteServerSyncHelper.java:351)
132 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at it.niedermann.owncloud.notes.persistence.NoteServerSyncHelper$SyncTask.doInBackground(NoteServerSyncHelper.java:277)
133 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at it.niedermann.owncloud.notes.persistence.NoteServerSyncHelper$SyncTask.doInBackground(NoteServerSyncHelper.java:248)
134 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at android.os.AsyncTask$3.call(AsyncTask.java:378)
135 12-27 07:04:53.493 2145 2185 E AndroidRuntime: at java.util.concurrent.FutureTask.run(FutureTask.java:266)
136 12-27 07:04:53.493 2145 2185 E AndroidRuntime: ... 4 more