feat: apply personal out-of-office data to the auto responder#9077
feat: apply personal out-of-office data to the auto responder#9077ChristophWurst merged 1 commit intomainfrom
Conversation
st3iny
force-pushed
the
feat/ooo-auto-responder-integration
branch
2 times, most recently
from
a5fe9c2 to
f1afc7d
Compare
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Amazing
We will need to suppress some missing classes for Psalm
|
Psalm is still not happy |
|
/backport to stable3.5 |
| } | ||
|
|
||
| public function handle(Event $event): void { | ||
| if (!($event instanceof OutOfOfficeStartedEvent) && !($event instanceof OutOfOfficeEndedEvent)) { |
There was a problem hiding this comment.
currently not covered: ooo changed event. listening to that would allow Mail to reflect changes to the ooo message when ooo is ongoing
There was a problem hiding this comment.
the current feature set is fine for an mvp. we can add change propagation later.
|
OCP packages were outdated. Psalm passes now after rerun. |
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Tested & works
It's also super nice to see that the same account configured on an installation of this branch is compatible with a 3.5.0rc1 installation. The other installation still recognizes the autoresponder as enabled with the data set from the new automation.
Signed-off-by: Richard Steinmetz <[email protected]> Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
feat/ooo-auto-responder-integration
branch
from
6f8c0fb to
3cbdf1f
Compare
|
/backport to stable3.5 |
2 participants
Fix #8925
Requires nextcloud/server#41440
I had to move the sieve "parser" to the backend. There should be no regressions and it should behave exactly like before. Proof: I moved all tests and test data to the backend and they all pass without modifications.
Note: This PR looks huge but to be fair there are a lot of tests and test data.
TODO