Consider passwordless signins when provisioning accounts#5944
Merged
miaulalala merged 1 commit intomainfrom May 12, 2022
Merged
Consider passwordless signins when provisioning accounts#5944miaulalala merged 1 commit intomainfrom
miaulalala merged 1 commit intomainfrom
Conversation
nickvergessen
approved these changes
Jan 13, 2022
Contributor
Author
|
this needs some more work as the Imap Client needs a password. So just setting it to "null" will break our current workflow. |
ChristophWurst
approved these changes
May 12, 2022
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Provisioned accounts might still not work if the user never logs into a session with password. But an occasional passwordless login will now be possible 👍
Member
|
/backport to stable1.12 |
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
fix/take-sso-into-consideration-when-provisioning
branch
from
73d829a to
8ae7b9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a null check on the password and skip updating the password for these accounts.
Fixes #5933