Merged
Conversation
ChristophWurst
force-pushed
the
enhancement/persist-provisioned-account
branch
2 times, most recently
from
02f1983 to
d8fb682
Compare
ChristophWurst
force-pushed
the
enhancement/persist-provisioned-account
branch
5 times, most recently
from
214ad04 to
d12c387
Compare
rullzer
reviewed
Dec 4, 2019
rullzer
approved these changes
Dec 4, 2019
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Didn't test. But code looks good
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
enhancement/persist-provisioned-account
branch
from
d12c387 to
ad29c8a
Compare
This was referenced Dec 17, 2019
Closed
|
Came across this from closing #425 info: I wonder if I under stand the check "When a user accesses a provisioned account, set the (until then) missing password" right: The password for the (formerly called) default account will be stored in the database, just as it is done for quite a while with additional mail accounts? |
Member
Author
|
Yes, that is correct. For further questions please use https://help.nextcloud.com/c/apps/mail :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default accounts will be a bit tricky to handle in the future, as we will often need access to accounts, even if the user is not logged in (background jobs). Moreover, you can't persist any settings as they all share the same -2 id across all users.
Thus, the idea is to just persist them. Admins shall from now on configure this only through the web UI, hence adding a settings interface.
Todo
Current (2019-11-15) state