Skip to content

Comments

fix: warning for accounts that can't connect#12027

Merged
GretaD merged 1 commit intomainfrom
add/account-error-no-connection
Nov 14, 2025
Merged

fix: warning for accounts that can't connect#12027
GretaD merged 1 commit intomainfrom
add/account-error-no-connection

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented Nov 13, 2025

fixes #11918

Having the icon in front of the account address it will not work because NcAppNavigationCaption doesnt allow us to add an icon.
i think this is a nice solution as well
Screenshot from 2025-11-13 18-21-49

@nimishavijay @marcoambrosini for design approval

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the previous warning triangle just vanished?

@ChristophWurst
Copy link
Member

Ticket link missing

@GretaD
Copy link
Contributor Author

GretaD commented Nov 14, 2025

So the previous warning triangle just vanished?

yes, i tried to track it down when, and i couldnt find it. It must have been long time ago. Most probably before we used the current component.

@GretaD GretaD merged commit a5bb4b6 into main Nov 14, 2025
44 checks passed
@GretaD GretaD deleted the add/account-error-no-connection branch November 14, 2025 10:33
@kesselb
Copy link
Contributor

kesselb commented Nov 14, 2025

/backport to stable5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show warning triangle for accounts that can't connect

3 participants