Skip to content

Comments

feat: thread attachement list front end#11608

Merged
hamza221 merged 1 commit intomainfrom
enh/attachement-list
Jan 15, 2026
Merged

feat: thread attachement list front end#11608
hamza221 merged 1 commit intomainfrom
enh/attachement-list

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented Sep 1, 2025 •
edited
Loading

image

@hamza221 hamza221 self-assigned this Sep 1, 2025
@hamza221 hamza221 force-pushed the enh/attachement-list branch from eadf0d8 to 74f85e9 Compare December 5, 2025 14:05
@hamza221 hamza221 changed the base branch from main to feat/envelope-lists December 5, 2025 14:06
@hamza221 hamza221 force-pushed the feat/envelope-lists branch from fac228d to ee4ce1f Compare January 12, 2026 14:50
@hamza221 hamza221 mentioned this pull request Jan 13, 2026
Open
3 tasks
@hamza221 hamza221 force-pushed the enh/attachement-list branch from 74f85e9 to 3d70e70 Compare January 13, 2026 16:26
@hamza221 hamza221 changed the base branch from feat/envelope-lists to main January 13, 2026 16:27
@hamza221 hamza221 marked this pull request as ready for review January 13, 2026 20:28
@hamza221 hamza221 requested a review from nimishavijay January 13, 2026 20:32
ChristophWurst
ChristophWurst reviewed Jan 14, 2026
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

@hamza221 hamza221 force-pushed the enh/attachement-list branch 2 times, most recently from 5a50de5 to a2ed679 Compare January 14, 2026 23:51
@ChristophWurst ChristophWurst changed the title enh: thread attachement list front end feat: thread attachement list front end Jan 15, 2026
@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 15, 2026 •
edited by hamza221
Loading

  • BUG I see attachments (sometimes also just a +1 when it's the sole attachment) but clicking just open the email, and then the list item no longer has an attachment

Before click/navigation
Bildschirmfoto vom 2026-01-15 14-29-02
After
Bildschirmfoto vom 2026-01-15 14-29-09
The attachment
Bildschirmfoto vom 2026-01-15 14-29-15

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 15, 2026 •
edited by hamza221
Loading

  • BUG handling of parts with no name (embedded emails)
Bildschirmfoto vom 2026-01-15 14-32-54 Bildschirmfoto vom 2026-01-15 14-33-00

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 15, 2026 

 TypeError: can't access property "split", this.fileName is null
    mounted FileIcon.vue:77
    VueJS 19
    addEnvelopesMutation actions.js:2039
    addEnvelopesMutation actions.js:2035
    r pinia.mjs:1399
    fetchEnvelopes actions.js:693
    ge tap.js:26
    a _dispatchable.js:38
    t _curry2.js:19
    t _curry1.js:16
    promise callback*49519/pe< andThen.js:46
    t _curry2.js:19
    t _curry1.js:16
    C _pipe.js:3
    r _arity.js:10
    fetchEnvelopes actions.js:699
    s sessionExpiryHandler.js:13
    fetchEnvelopes actions.js:673
    r pinia.mjs:1399
    loadEnvelopes

@hamza221
Copy link
Contributor Author

hamza221 commented Jan 15, 2026

  • BUG I see attachments (sometimes also just a +1 when it's the sole attachment)

Screen shot look like you have a tiny viewport, attachements would only show if there's enough space

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 15, 2026

Yes it is my 1080p poverty screen

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 15, 2026

I confirm that moving the dev tools to the bottom and making the middle column wider there is no more +1

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 15, 2026 •
edited by hamza221
Loading

  • BUG clicking on an attachment name should preview the file, but not open that email.

ChristophWurst
ChristophWurst approved these changes Jan 15, 2026
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this does the trick

The few reported bucks remain

@hamza221 hamza221 force-pushed the enh/attachement-list branch from a2ed679 to c6de968 Compare January 15, 2026 17:35
@hamza221 hamza221 force-pushed the enh/attachement-list branch from c6de968 to 7cb3b70 Compare January 15, 2026 21:49
@hamza221 hamza221 merged commit 43a668a into main Jan 15, 2026
45 checks passed
@hamza221 hamza221 deleted the enh/attachement-list branch January 15, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

@hamza221 hamza221

Labels

3. to review enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hamza221 @ChristophWurst