feat: provide attachement names for messages#11596
Merged
Conversation
Contributor
Author
|
I realized this can be merged independently from #11529, rebasing |
hamza221
force-pushed
the
feat/thread-attachements
branch
from
c8079fb to
185eb96
Compare
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Works, but I'm not a big fan. It's using the distributed cache as storage. Cons:
- Does not work when there is no distributed cache. It will still do the expensive fetching, but the results are losts.
- For small installations that use APCu for local+distributed caching this will inflate cache memory quite a bit and risk that the cache is fully evicted because it's running full.
| $result = array_map(static function (array $attachment) { | ||
| return $attachment['fileName']; | ||
| }, $attachments); | ||
| $this->cache->set($message->getUid(), $result); |
Member
There was a problem hiding this comment.
UIDs are unique in the scope of a single mailbox. You'll run into conflicts across mailboxes, and worse, across user accounts. Use the primary key or find another unique identifier.
ChristophWurst
approved these changes
Aug 29, 2025
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Read the code wrong. Does exactly what we discussed 
hamza221
force-pushed
the
feat/thread-attachements
branch
from
0ddc79c to
b3596f2
Compare
This was referenced Jan 13, 2026
ChristophWurst
approved these changes
Jan 14, 2026
hamza221
force-pushed
the
feat/thread-attachements
branch
from
313cea8 to
695f15d
Compare
Signed-off-by: Hamza <[email protected]>
hamza221
force-pushed
the
feat/thread-attachements
branch
from
695f15d to
aebeb8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.