perf: read larger chunks in logiterator#1179
Merged
icewind1991 merged 2 commits intomasterfrom Mar 12, 2024
Merged
Conversation
Signed-off-by: Robin Appelman <[email protected]>
nickvergessen
approved these changes
Mar 11, 2024
come-nc
approved these changes
Mar 11, 2024
Contributor
|
this makes it work better with chunk size > line length Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
logiterator-larger-chunks
branch
from
835c7d6 to
32f93c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This speeds up iterating through log files by about 30x in my testing
8192 is chosen because it's the size of the php internal read buffer