Ios27 fix - #4192
Merged
Merged
Conversation
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to address behavior changes encountered on iOS 27 by adjusting search controller dismissal handling and by modifying a couple of async callback capture patterns in viewer/media code. It also includes a project build-number bump and a minor whitespace cleanup.
Changes:
- Add
willDismissSearchController(_:)handling to reset search UI/state when dismissing search. - Update async completion closures in media viewer/media grid code (currently removing
[weak self]in two places). - Bump
CURRENT_PROJECT_VERSIONfor the app target build settings (1 → 2).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Nextcloud.xcodeproj/project.pbxproj | Updates build setting CURRENT_PROJECT_VERSION (build number). |
| iOSClient/Viewer/NCViewerMedia/Views/NCMediaViewerFloatingTitleView.swift | Removes trailing whitespace/newline at EOF. |
| iOSClient/Viewer/NCViewerMedia/NCMediaViewerHostingController.swift | Adjusts EXIF fetch completion handling used to present the detail sheet. |
| iOSClient/Media/NCMedia+CollectionViewDataSource.swift | Adjusts transfer operation closure used to download/load previews for media cells. |
| iOSClient/Main/Collection Common/NCCollectionViewCommon.swift | Adds search dismissal handling and reorders setSearchBarLoading. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+375
to
379
| NCUtility().getExif(metadata: metadata) { exif in | ||
| Task { @MainActor in | ||
| guard let self else { | ||
| return | ||
| } | ||
|
|
||
| self.presentDetailView( | ||
| metadata: metadata, | ||
| index: index, |
Comment on lines
64
to
70
| await NCTransferCoordinator.shared.start( | ||
| identifier: ocId, | ||
| priority: .visible | ||
| ) { [weak self] in | ||
| guard let self, | ||
| let metadata = await NCManageDatabase.shared.getMetadataFromOcIdAsync(ocId) else { | ||
| ) { | ||
| guard let metadata = await NCManageDatabase.shared.getMetadataFromOcIdAsync(ocId) else { | ||
| return | ||
| } |
| CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; | ||
| COPY_PHASE_STRIP = NO; | ||
| CURRENT_PROJECT_VERSION = 1; | ||
| CURRENT_PROJECT_VERSION = 2; |
Signed-off-by: Marino Faggiana <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fix encountered in iOS 27 with Xcode 27 beta