Fix VoiceOver labels in share extension folder picker - #4111
Merged
mpivchev merged 1 commit intoMay 28, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves VoiceOver support in the Share Extension鈥檚 target-folder picker by explicitly setting accessibility metadata on folder cells so selectable rows are announced with meaningful text.
Changes:
- Build an
accessibilityLabelfrom the folder name plus existing cell metadata text. - Apply the accessibility label/value to
NCListCellinstances in the share extension. - Mark folder rows as actionable by setting
accessibilityTraitsto.button.
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+107
to
+112
| let accessibilityLabel = [metadata.fileNameView, cell.labelInfo.text, cell.labelSubinfo.text] | ||
| .compactMap { $0?.trimmingCharacters(in: .whitespacesAndNewlines) } | ||
| .filter { !$0.isEmpty } | ||
| .joined(separator: ", ") | ||
| cell.setAccessibility(label: accessibilityLabel, value: "") | ||
| cell.accessibilityTraits = .button |
Collaborator
|
Hi @web3blind, thank you for the PR! |
mpivchev
self-requested a review
May 20, 2026 09:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue
Fixes #4099
Testing
Accessibility impact
This should let VoiceOver announce the folder name/details while sharing a file into Nextcloud from another app, instead of focusing unnamed selectable rows.