add mariadb image.registry fallback to docker.io and update docs for mariadb.image parameters#495
Merged
jessebot merged 2 commits intonextcloud:mainfrom Dec 15, 2023
Conversation
…mariadb.image parameters Signed-off-by: jessebot <[email protected]>
… up to date Signed-off-by: jessebot <[email protected]>
provokateurin
approved these changes
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
This just adds some docs for
mariadb.imageand adds a fallback for the image.registry parameter.Benefits
This just makes postgres and mariadb a bit more consistent and adds docs
Possible drawbacks
we can't reasonably maintain the image tag in the docs, because it would change everytime we update the subcharts, so I've left it blank.
Applicable issues
This fixes the issue brought up in #471 (comment)
Additional information
Checklist
Chart.yamlaccording to semver.