Skip to content

feat(docs): Document service discovery with nginx and ingress#491

Merged
provokateurin merged 1 commit intomainfrom
feat/docs/service-discovery-nginx-ingress
Dec 3, 2023
Merged

feat(docs): Document service discovery with nginx and ingress#491
provokateurin merged 1 commit intomainfrom
feat/docs/service-discovery-nginx-ingress

Conversation

@provokateurin
Copy link
Copy Markdown
Member

@provokateurin provokateurin commented Dec 2, 2023

Pull Request

Description of the change

Documents how to get the service discovery working in case of using nginx and ingress.

Benefits

People (including me) struggled with the service discovery because it was not documented how to get it working. The server snippet was already in the values, but it was nowhere mentioned that it is needed.

Possible drawbacks

None, only more documentation.

Applicable issues

Additional information

@qlonik @adborden Please test if this solves your problems (I couldn't directly request a review from you).

Checklist

@provokateurin provokateurin added documentation Improvements or additions to documentation nginx container issues related to the nginx container bundling in the nextcloud pod. Ingress Anything to do with ingress or ingress controllers labels Dec 2, 2023
@provokateurin provokateurin force-pushed the feat/docs/service-discovery-nginx-ingress branch from 96ca88e to 837e1d8 Compare December 2, 2023 10:49
@jessebot
Copy link
Copy Markdown
Collaborator

jessebot commented Dec 2, 2023 •
edited
Loading

People (including me) struggled

That's so real haha shared nextcloud community experience getting this php app working in the cloud :D

For the actual content of this PR: 🤔 I haven't tried this yet, but this does seem to follow what I was trying once upon a time here: #410 (comment)

I will assume it works based on your findings in #410 but can we please hold off on closing that issue till I get a chance to test this as well?

@provokateurin
Copy link
Copy Markdown
Member Author

provokateurin commented Dec 2, 2023

Oh interesting I forgot that you tried this. Maybe you had the same caching issues as I had. We can totally leave this issue open for you to test. My instance is fixed now and that's all I care about right now 😅

@jessebot
Copy link
Copy Markdown
Collaborator

jessebot commented Dec 3, 2023

Oh interesting I forgot that you tried this. Maybe you had the same caching issues as I had.

Yeah, I'm hoping it's cache or the cors issue was biting me 😅, but I've been battle testing the s3 object storage backend, and more recently getting rid of the nginx container, for weeks and haven't had the chance to look into this issue again. Team work though! We're gonna make it work!

Also approved this. You can merge when you're ready :)

@provokateurin provokateurin force-pushed the feat/docs/service-discovery-nginx-ingress branch from 837e1d8 to a793da0 Compare December 3, 2023 10:55
@provokateurin provokateurin merged commit e057df8 into main Dec 3, 2023
@provokateurin provokateurin deleted the feat/docs/service-discovery-nginx-ingress branch December 3, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessebot jessebot jessebot approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation Ingress Anything to do with ingress or ingress controllers nginx container issues related to the nginx container bundling in the nextcloud pod.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

caldav/carddav: principal ... does not provide caldav service followed by 405 error

2 participants

@provokateurin @jessebot