Merged
Conversation
Documentation IssueNumber: 236 Signed-off-by: Veymax <[email protected]>
Signed-off-by: Veymax <[email protected]>
jessebot
reviewed
Nov 18, 2023
jessebot
requested changes
Nov 18, 2023
Collaborator
jessebot
left a comment
jessebot
left a comment
There was a problem hiding this comment.
looks good, just remove the version bump only because the chart itself is not changing. Thanks for clarification :)
Signed-off-by: JesseBot <[email protected]>
jessebot
approved these changes
Nov 18, 2023
Collaborator
jessebot
left a comment
jessebot
left a comment
There was a problem hiding this comment.
just realized I had permissions to edit this, so I removed the chart version bump. thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Documentation update to close out issue #236
Benefits
Clearer documentation to avoid a frequent trip-up with users when filling in the values.yaml file
Possible drawbacks
Slightly wordier documentation
Applicable issues
Additional information
Opted to put this clarifying note in just the README and not the values file itself to avoid clutter. If someone is confused about what to put in the username, or having issues, they will naturally check the README, where this should then help them.
Checklist
Chart.yamlaccording to semver.