Use new sidebar api to register groupfolders section#507
Merged
juliusknorr merged 1 commit intomasterfrom Dec 16, 2019
Merged
Conversation
juliusknorr
added
2. developing
25 tasks
14 tasks
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
enhancement/17-use-sidebar-section-api
branch
from
9f80199 to
100b178
Compare
juliusknorr
added
3. to review
skjnldsv
reviewed
Dec 5, 2019
| if (fileInfo.mountType !== 'group') { | ||
| return | ||
| } | ||
| return Module.default |
Member
There was a problem hiding this comment.
interesting, dynamic import needs us to specify defaukt ?
Member
Author
There was a problem hiding this comment.
yes, it will return an object with all the exports
skjnldsv
approved these changes
Dec 5, 2019
Member
|
Shall we merge? |
Member
Author
|
Yes, we need to make sure to have a version release just for 18 then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires nextcloud/server#16312