Skip to content

Comments

expose groupfolder through dav endpoint#2326

Merged
skjnldsv merged 4 commits intomasterfrom
dav-api
Apr 20, 2023
Merged

expose groupfolder through dav endpoint#2326
skjnldsv merged 4 commits intomasterfrom
dav-api

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Apr 12, 2023 •
edited by skjnldsv
Loading

expose groupfolders at /remote.php/dav/groupfolders/<user id>

you can also request the mount point for the group folder by requesting the {http://nextcloud.org/ns}mount-point property

@icewind1991 icewind1991 added the 3. to review Items that need to be reviewed label Apr 12, 2023
@icewind1991 icewind1991 mentioned this pull request Apr 12, 2023
Closed
2 tasks
@skjnldsv

This comment was marked as resolved.

Sign in to view
@icewind1991

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv mentioned this pull request Apr 19, 2023
Merged
artonge
artonge reviewed Apr 19, 2023
View reviewed changes
@skjnldsv skjnldsv added 2. developing Items that are currently under development and removed 3. to review Items that need to be reviewed labels Apr 19, 2023
@skjnldsv skjnldsv requested a review from artonge April 20, 2023 10:29
@skjnldsv skjnldsv added 3. to review Items that need to be reviewed and removed 2. developing Items that are currently under development labels Apr 20, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Apr 20, 2023

Ready for my part 👍
devcom_apps_files_groupfolders_dir=_

@skjnldsv
Copy link
Member

skjnldsv commented Apr 20, 2023

@artonge @icewind1991 if you have some time to quickly test the front, would be nice! :)

artonge
artonge reviewed Apr 20, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If no actions available, should we allow selection?
  • Is there a way to provide icons to be displayed on the folder or file icon to differentiate groupfolder, share, e2ee, ...
  • The home icon is useless, can it be removed?

@skjnldsv
Copy link
Member

skjnldsv commented Apr 20, 2023 •
edited
Loading

  • If no actions available, should we allow selection?

For server

  • Is there a way to provide icons to be displayed on the folder or file icon to differentiate groupfolder, share, e2ee, ...

Will be, also for server. The old way was a bit hacky, I will provide a dedicated MimeIcon API to register inline svg
EDIT: seems the current way is different than the mime API already in place. I will see what I can come up with :)

  • The home icon is useless, can it be removed?

It's not, clicking the last breadcrumb refreshes the current folder.
Here it would refresh the list of groupfolders (as in legacy files)
Nonetheless, this would be an issue for server and in the future, there is no doubt the groupfolder will not be just a redirect anymore but fully browsable. Let's keep it like that :)

@skjnldsv skjnldsv merged commit f467c96 into master Apr 20, 2023
@skjnldsv skjnldsv deleted the dav-api branch April 20, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge artonge approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner

Assignees

No one assigned

Labels

3. to review Items that need to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991 @skjnldsv @artonge