Skip to content

fix logger for stdout - #9975

Merged
nilsding merged 2 commits into
nextcloud:masterfrom
an-dr-eas-k:feature/logger_fix
May 8, 2026
Merged

fix logger for stdout#9975
nilsding merged 2 commits into
nextcloud:masterfrom
an-dr-eas-k:feature/logger_fix

Conversation

@an-dr-eas-k

Copy link
Copy Markdown
Contributor

Resolves

#9974

Summary

checks whether _logfile is present. If not, skip rolling log file.

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@nilsding nilsding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm, thank you so much for your contribution! :D

@nilsding

nilsding commented May 7, 2026

Copy link
Copy Markdown
Member

@an-dr-eas-k could you amend your commit with a Sign-off message and rebase on the latest master commit?

@an-dr-eas-k
an-dr-eas-k force-pushed the feature/logger_fix branch 2 times, most recently from cab6c13 to e9c77dd Compare May 7, 2026 18:36
@an-dr-eas-k an-dr-eas-k closed this May 7, 2026
@an-dr-eas-k
an-dr-eas-k force-pushed the feature/logger_fix branch from e9c77dd to 9ac8d75 Compare May 7, 2026 18:42
Signed-off-by: AndreasK <[email protected]>
@an-dr-eas-k an-dr-eas-k reopened this May 7, 2026
@an-dr-eas-k

Copy link
Copy Markdown
Contributor Author

I merged upstream and signed-off my commit. Cheers.

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-9975.zip

Digest: sha256:0d433a670958f397382d2f65ecb56b9d84200f5eda005da691266d77f58cdeb2

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding
nilsding enabled auto-merge May 8, 2026 07:10
@nilsding

nilsding commented May 8, 2026

Copy link
Copy Markdown
Member

/backport to stable-4.0 please

@nilsding

nilsding commented May 8, 2026

Copy link
Copy Markdown
Member

/backport to stable-33.0 please

@nilsding nilsding added this to the 34.0.0 milestone May 8, 2026
@nilsding
nilsding merged commit 9381842 into nextcloud:master May 8, 2026
19 of 21 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: When logging to stdout with nextcloudcli the logger halts the process

3 participants