fix(discovery): do not sync shares with "Allow download and sync" unset - #9963
Merged
Conversation
Member
Author
|
/backport to stable-33.0 |
nilsding
force-pushed
the
bugfix/noid/no-download-and-sync-folders
branch
from
May 13, 2026 12:43
cde4c08 to
a7f0efb
Compare
|
nilsding
force-pushed
the
bugfix/noid/no-download-and-sync-folders
branch
2 times, most recently
from
May 18, 2026 09:46
cc096f3 to
bc3c581
Compare
Rello
approved these changes
May 19, 2026
Signed-off-by: Jyrki Gadinger <[email protected]>
… permission The permission does not only apply to files, but also to folders. Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Jyrki Gadinger <[email protected]>
otherwise cfapi would list folders that are skipped by the sync engine itself Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
force-pushed
the
bugfix/noid/no-download-and-sync-folders
branch
from
May 19, 2026 07:36
bc3c581 to
774e04e
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9963.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option does not only apply to files, but also to folders.
Also: do not display shared items without that option in Windows on-demand folders
Checklist
AI (if applicable)