fix(cfapi): avoid creation of db records if CfExecute failed - #9912
Merged
Conversation
Member
Author
|
/backport to stable-33.0 please |
when the call to CfExecute fails (e.g. due to "The cloud operation was
canceled by user.") consider all new placeholders as invalid.
VfsCfApi::finalizeNewPlaceholders won't create a new metadata record for
new, errored items which would cause random deletions in a future sync due
to the combination of {db: exists, local: absent, remote: exists}
=> (placeholder) item was apparently removed locally; even though only the
creation of the item failed ...
Signed-off-by: Jyrki Gadinger <[email protected]>
…in discovery Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
force-pushed
the
bugfix/9858/win32-random-deletions
branch
from
April 27, 2026 08:41
0689bdc to
ba534c6
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9912.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
mgallien
approved these changes
Apr 27, 2026
nilsding
marked this pull request as ready for review
April 27, 2026 09:11
This was
linked to
issues
Apr 27, 2026
|
Member
Author
|
/backport to stable-4.0 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the call to CfExecute fails (e.g. due to "The cloud operation was canceled by user.") consider all new placeholders as invalid.
VfsCfApi::finalizeNewPlaceholders won't create a new metadata record for new, errored items which would cause random deletions in a future sync due to the combination of {db: exists, local: absent, remote: exists} => (placeholder) item was apparently removed locally; even though only the creation of the item failed ...
should help with #8983, #9858