Remove Windows Shell/Explorer pinning fallback commands from SocketApi - #9819
Merged
mgallien merged 1 commit intoApr 10, 2026
Merged
Conversation
Rello
requested review from
Aiiaiiio,
camilasan,
i2h3,
mgallien and
nilsding
as code owners
April 9, 2026 10:05
mgallien
approved these changes
Apr 9, 2026
mgallien
enabled auto-merge
April 9, 2026 10:28
These fallback handlers were kept for legacy shell verb compatibility. With current-client-only integrations, they are no longer needed. Signed-off-by: Rello <[email protected]>
nilsding
force-pushed
the
codex/evaluate-and-possibly-remove-obsolete-code-section
branch
from
April 10, 2026 09:18
fa2b631 to
4a03da3
Compare
nilsding
approved these changes
Apr 10, 2026
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9819.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
mgallien
deleted the
codex/evaluate-and-possibly-remove-obsolete-code-section
branch
April 10, 2026 09:55
Member
|
/backport to stable-33.0 |
Member
|
/backport to stable-4.0 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#ifdef Q_OS_WINand referenced in issue trackers.Description
command_COPYASPATH,command_OPENNEWWINDOW, andcommand_OPENfromsrc/gui/socketapi/socketapi.cpp.Q_INVOKABLEdeclarations forcommand_COPYASPATH,command_OPENNEWWINDOW, andcommand_OPENfromsrc/gui/socketapi/socketapi.h.#ifdef Q_OS_WIN/#endifwrapper and related fallback logic to simplify platform-specific handling inSocketApi.Testing
Codex Task