fix(integration): only call parseEndpoints if fileId is not empty. - #9701
Merged
Conversation
camilasan
changed the title
camilasan
marked this pull request as ready for review
March 26, 2026 18:41
camilasan
requested review from
Aiiaiiio,
i2h3,
mgallien and
nilsding
as code owners
March 26, 2026 18:41
camilasan
force-pushed
the
bugfix/noid/emptyfileid
branch
from
March 26, 2026 18:42
3f2425b to
165e140
Compare
Member
Author
|
/backport to stable-33.0 |
nilsding
approved these changes
Mar 26, 2026
Signed-off-by: Camila Ayres <[email protected]>
… folder is found. Signed-off-by: Camila Ayres <[email protected]>
mgallien
enabled auto-merge
March 26, 2026 20:44
mgallien
force-pushed
the
bugfix/noid/emptyfileid
branch
from
March 26, 2026 20:44
165e140 to
b936a60
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9701.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When right clicking on a file and on File actions, the users was always seeing the error "The file ID is empty for ".
We can not control when QML instantiates the file id, but we can make sure the file id is not set to empty. For file provider the local path also needs to be validated.