Skip to content

feature(icon/ai): improved Nextcloud Assistant icon - #9658

Merged
mgallien merged 1 commit into
masterfrom
feature/betterAssistantIcon
Mar 20, 2026
Merged

feature(icon/ai): improved Nextcloud Assistant icon#9658
mgallien merged 1 commit into
masterfrom
feature/betterAssistantIcon

Conversation

@mgallien

@mgallien mgallien commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@mgallien mgallien added this to the 34.0.0 milestone Mar 20, 2026
@mgallien
mgallien requested a review from kra-mo March 20, 2026 10:55
@mgallien

mgallien commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-33.0

@mgallien

mgallien commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

before
image

after
image

@mgallien
mgallien force-pushed the feature/betterAssistantIcon branch from 129d633 to 6b8d288 Compare March 20, 2026 11:08
nilsding
nilsding requested changes Mar 20, 2026
View reviewed changes
Comment thread theme/black/nc-assistant-app.svg

@nilsding nilsding Mar 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this one be the variant with the dark gradient?

@mgallien mgallien Mar 20, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main issue there is that we do color the icons relatively to the header bar color
the header bar color do not change when switching between dark and light modes
I followed the always white practice from the other icons

@github-actions

github-actions Bot commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-9658.zip

Digest: sha256:74952bd384515939eacc6897e6694fb296ad7ebf0aa0269f81d515b4f1993d9d

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

sonarqubecloud Bot commented Mar 20, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mgallien
mgallien enabled auto-merge March 20, 2026 12:45
@mgallien
mgallien disabled auto-merge March 20, 2026 12:52
@mgallien
mgallien merged commit 1d257c3 into master Mar 20, 2026
23 of 26 checks passed
@mgallien
mgallien deleted the feature/betterAssistantIcon branch March 20, 2026 12:52
@backportbot backportbot Bot mentioned this pull request Mar 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsding nilsding nilsding approved these changes
@kra-mo kra-mo kra-mo approved these changes
@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio
@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner
@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

34.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mgallien @nilsding @kra-mo