fix(settings): add missing endGroup() in Folder::removeFromSettings - #9607
Conversation
60b4fd1 to
c8b2340
Compare
Done! |
|
/backport to stable-33.0 |
|
/backport to stable-4.0 |
nilsding
left a comment
nilsding
left a comment
There was a problem hiding this comment.
thanks for your contribution!
c77610f to
08e97d5
Compare
08e97d5 to
88c9a59
Compare
The last beginGroup("FoldersWithPlaceholders") call was never closed
with endGroup(), leaving the QSettings group stack unbalanced.
Signed-off-by: Stefan Agner <[email protected]>
88c9a59 to
9985c0e
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9607.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
4 participants
The last beginGroup("FoldersWithPlaceholders") call was never closed with endGroup(), leaving the QSettings group stack dirty.