Skip to content

Note about missing End-to-End Encryption Support in File Provider Extension - #9561

Merged
i2h3 merged 1 commit into
masterfrom
i2h3/feature/9471-fpe-e2e-note
Mar 4, 2026
Merged

Note about missing End-to-End Encryption Support in File Provider Extension#9561
i2h3 merged 1 commit into
masterfrom
i2h3/feature/9471-fpe-e2e-note

Conversation

@i2h3

@i2h3 i2h3 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

Closes #9471

@i2h3
feat(file-provider): Note about missing support for end-to-end encryp…
98762bf 
…tion in file provider extension.

Signed-off-by: Iva Horn <[email protected]>
@i2h3 i2h3 added this to the 33.0.0 milestone Mar 4, 2026
@i2h3 i2h3 self-assigned this Mar 4, 2026
@i2h3 i2h3 added feature: 🔒 end to end encryption os: 🍎 macOS Apple macOS, formerly also known as OS X labels Mar 4, 2026
@i2h3 i2h3 added the feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system. label Mar 4, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 💻 Desktop Clients team Mar 4, 2026
@i2h3 i2h3 changed the title Note about missing support for end-to-end encryption in file provider extension. Note about missing End-to-End Encryption Support in File Provider Extension Mar 4, 2026
@i2h3 i2h3 moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💻 Desktop Clients team Mar 4, 2026
@i2h3
i2h3 requested a review from Copilot March 4, 2026 08:48
@i2h3

i2h3 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-33.0

Copilot AI reviewed Mar 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the end-to-end encryption setup message in Account Settings to inform users (on macOS File Provider builds) that the virtual files integration does not currently support end-to-end encryption.

Changes:

  • Adds a BUILD_FILE_PROVIDER_MODULE-specific addition to the E2EE setup message text.
  • Refactors the label assignment to use a local encryptionMessage variable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/gui/accountsettings.cpp
Comment thread src/gui/accountsettings.cpp
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-9561.zip

Digest: sha256:c9cacd1176d5e583a47a13a6d5dacbd6b30174399d524484d4d8d4407f1ebd80

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

sonarqubecloud Bot commented Mar 4, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
21 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@i2h3
i2h3 merged commit 8bf3510 into master Mar 4, 2026
27 of 28 checks passed
@i2h3
i2h3 deleted the i2h3/feature/9471-fpe-e2e-note branch March 4, 2026 11:01
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Mar 4, 2026
@backportbot backportbot Bot mentioned this pull request Mar 4, 2026
Merged
@mgallien mgallien modified the milestones: 33.0.0, 34.0.0 Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio
@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner
@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner
@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

Assignees

@i2h3 i2h3

Labels

feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system. feature: 🔒 end to end encryption os: 🍎 macOS Apple macOS, formerly also known as OS X

Projects

None yet

Milestone

34.0.0

Development

Successfully merging this pull request may close these issues.

Note about Missing Encryption Support in File Provider Extension

4 participants

@i2h3 @mgallien @Rello