fix(accountmanager): check existing account proxy type setting. - #9551
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in AccountManager::migrateNetworkSettings where the wrong settings key ("networkProxySetting") was used to check whether an account is using a default or no proxy. Because that key never existed in the settings, settings.value(networkProxySettingC).toInt() always returned 0, causing global proxy settings to unconditionally override any per-account proxy configuration during migration. The fix removes the bogus constant and instead directly compares the already-read accountProxyType value against QNetworkProxy::NoProxy and QNetworkProxy::DefaultProxy, which is the correct and intended semantics.
Changes:
- Removed the unused and incorrect
networkProxySettingCconstant ("networkProxySetting") - Replaced the always-true
accountProxySetting == 0check with a semantically correct check againstQNetworkProxy::NoProxyandQNetworkProxy::DefaultProxy
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
13f2f81 to
9abf446
Compare
The setting networkProxySetting doesn't exist, the correct is networkProxyType to check if user has default before overriding it with global values. Signed-off-by: Camila Ayres <[email protected]>
9abf446 to
95ef8f8
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9551.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
|
/backport to stable-4.0 |
|
/backport to stable-33.0 |
The setting networkProxySetting doesn't exist, the correct is networkProxyType to check if user has default before overriding it with global values.