fix: suppress duplicate "The log output cannot be saved" popups - #9539
Merged
Conversation
Rello
requested review from
Aiiaiiio,
camilasan,
i2h3,
mgallien and
nilsding
as code owners
February 27, 2026 12:32
Collaborator
Author
|
fixes #9519 |
Closed
8 tasks
mgallien
approved these changes
Feb 27, 2026
Collaborator
Author
|
/backport to stable-33.0 |
mgallien
enabled auto-merge
February 27, 2026 16:36
mgallien
force-pushed
the
codex/fix-duplicate-log-output-error-popups
branch
from
February 27, 2026 16:36
b957d96 to
738c822
Compare
nilsding
approved these changes
Feb 27, 2026
Signed-off-by: Rello <[email protected]>
nilsding
force-pushed
the
codex/fix-duplicate-log-output-error-popups
branch
from
February 27, 2026 17:45
738c822 to
acc7b6a
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9539.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
bool _didShowLogWriteErrortoLoggerto record whether the write-failure dialog has already been shown.setLogFileNoLockto show the "The log output cannot be saved" popup only once per persistent failure and reset the flag after a successful open.setPermanentDeleteLogFileNoLockso both normal and permanent-delete log outputs behave consistently.