Fix FinderSync Extension - #9528
Merged
Merged
Conversation
…system. Signed-off-by: Iva Horn <[email protected]>
The FinderSync target contained a custom "Run Script" build phase which copied the branded icon assets into the extension bundle. Due to the lack of specification of output files it was run on every build, likely resulting in unnecessary and cacheable results. Signed-off-by: Iva Horn <[email protected]>
Xcode could no longer resolve the debugging symbols for the main binary. This fixes it. Signed-off-by: Iva Horn <[email protected]>
Check for a socket file to exist before trying to connect. Signed-off-by: Iva Horn <[email protected]>
This used to be necessary many years ago but no longer is. Signed-off-by: Iva Horn <[email protected]>
- Replaced socketApiSocketPath() with socketApiSocketUrl() - Improved logging - Fixed socket path Signed-off-by: Iva Horn <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
i2h3
requested review from
Aiiaiiio,
camilasan,
mgallien and
nilsding
as code owners
February 26, 2026 14:23
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to restore correct behavior of the macOS FinderSync extension by aligning the socket location/handling between the desktop client and the extension, plus a few supporting build/logging adjustments.
Changes:
- Switch the macOS SocketAPI helper from returning a
QStringpath to returning aQUrl, and use it to derive the local socket path in the desktop client. - Update FinderSync extension to use the App Group container root socket (
…/s) and improve logging/diagnostics. - Adjust macOS integration build steps (Xcode project script phase naming/outputs, mac-crafter dSYM copying) and modernize logging in the socket client.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/gui/socketapi/socketapi_mac.mm |
Changes SocketAPI helper to return a QUrl for the App Group socket location. |
src/gui/socketapi/socketapi.h |
Updates macOS SocketAPI declaration and includes QUrl to support by-value return. |
src/gui/socketapi/socketapi.cpp |
Uses the new macOS socket URL helper, adds debug logging around listen/startup. |
shell_integration/MacOSX/NextcloudIntegration/NextcloudIntegration.xcodeproj/project.pbxproj |
Renames shell script phase and adds an output path for incremental builds. |
shell_integration/MacOSX/NextcloudIntegration/NCDesktopClientSocketKit/LocalSocketClient.m |
Switches from NSLog to os_log, adds logger creation, minor string fix. |
shell_integration/MacOSX/NextcloudIntegration/FinderSyncExt/Info.plist |
Removes NSPrincipalClass entry for the extension. |
shell_integration/MacOSX/NextcloudIntegration/FinderSyncExt/FinderSync.m |
Updates socket path derivation and logging; adds existence check before starting client. |
admin/osx/mac-crafter/Sources/Commands/Build.swift |
Copies main app dSYM in dev mode and adjusts shell integration dSYM path selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rello
approved these changes
Feb 26, 2026
Collaborator
Author
|
/backport to stable-33.0 |
|
😍🤞 |
nilsding
approved these changes
Feb 26, 2026
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9528.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Iva Horn <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
i2h3
force-pushed
the
i2h3/fix/findersync
branch
from
February 26, 2026 15:47
ebe7a59 to
289bdbd
Compare
github-project-automation
Bot
moved this from 🧭 Planning evaluation (don't pick)
to ☑️ Done
in 💻 Desktop Clients team
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the correct function of the FinderSync extension on macOS. Several small changes on the way. See commit messages for details.