Bugfix/e2ee fixes for hardware certificate end to end encryption - #9514
Merged
Conversation
mgallien
force-pushed
the
bugfix/e2eeFixCertificateMigration
branch
4 times, most recently
from
February 25, 2026 14:44
90afdf0 to
efc1737
Compare
mgallien
changed the title
mgallien
marked this pull request as ready for review
February 26, 2026 08:40
mgallien
requested review from
Aiiaiiio,
camilasan,
i2h3 and
nilsding
as code owners
February 26, 2026 08:40
mgallien
force-pushed
the
bugfix/e2eeFixCertificateMigration
branch
from
February 26, 2026 08:58
b14efb0 to
dfa1c77
Compare
nilsding
approved these changes
Feb 26, 2026
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9514.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
nilsding
force-pushed
the
bugfix/e2eeFixCertificateMigration
branch
from
February 26, 2026 20:01
15b26ba to
ffe94a9
Compare
Collaborator
Author
|
/backport to stable-33.0 |
mgallien
enabled auto-merge
February 26, 2026 21:05
mgallien
disabled auto-merge
February 26, 2026 21:06
we need to use the certificate that was used to encrypt folder metadata when reading and decrypting them Signed-off-by: Matthieu Gallien <[email protected]>
we also want to get the fingerprint of a software certificate not only for hardware ones should enable us to have correct behavior in all cases (and maybe be able to migrate software certificates if there is a need) Signed-off-by: Matthieu Gallien <[email protected]>
during discovery of all certificates, the private key handle can become invalid to avoid having invalid references, rather store the certificate handle and use it to get the cached key Signed-off-by: Matthieu Gallien <[email protected]>
ensure the proper owner user certificate is used after a migration Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/e2eeFixCertificateMigration
branch
from
February 26, 2026 21:07
ffe94a9 to
e216d97
Compare
|
Member
|
/backport to stable-33.0 |
Collaborator
Author
|
/backport to stable-4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.