Skip to content

fix: use text emoji replacements to avoid creating duplicate labels - #9487

Merged
nilsding merged 1 commit into
masterfrom
fix/noid/auto-labels
Feb 23, 2026
Merged

fix: use text emoji replacements to avoid creating duplicate labels#9487
nilsding merged 1 commit into
masterfrom
fix/noid/auto-labels

Conversation

@nilsding

Copy link
Copy Markdown
Member

No description provided.

@i2h3

i2h3 commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

I have to object because GitHub Copilot criticized exactly this in its review of my pull request: #9479 (comment)

The label names include GitHub-style emoji shortcodes (e.g., 馃崕). Label names are plain text and won't render these shortcodes as emoji, so you'll end up with literal 馃崕 in the label name. If the intention is to show emojis in the label list, use the actual unicode characters (or drop the emoji portion).

I would also be fine to just get rid of emojis in labels entirely. 馃檪 That would prevent problems like these by design and also improve accessibility, as far as I know.

@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-9487.zip

Digest: sha256:6f02febe3c2cdd35bb750abb35a5a91955b72874207f170f400c00bceea0b803

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding

Copy link
Copy Markdown
Member Author

GitHub Copilot doesn't seem to be aware that emoji shortcodes in labels are rendered on GitHub. Right now these labels use those shortcodes, this can be verified from the public REST endpoint https://api.github.com/repos/nextcloud/desktop/labels?per_page=100 (e.g. "name": "os: :apple: macOS",).

I've seen this action creating a new label because of that and was confused at why the colour was different and why there suddenly were two labels with the same display name :D

@sonarqubecloud

Copy link
Copy Markdown

@nilsding
nilsding merged commit 1c344c0 into master Feb 23, 2026
23 of 24 checks passed
@nilsding
nilsding deleted the fix/noid/auto-labels branch February 23, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants