fix: use text emoji replacements to avoid creating duplicate labels - #9487
Conversation
Signed-off-by: Jyrki Gadinger <[email protected]>
|
I have to object because GitHub Copilot criticized exactly this in its review of my pull request: #9479 (comment)
I would also be fine to just get rid of emojis in labels entirely. 馃檪 That would prevent problems like these by design and also improve accessibility, as far as I know. |
|
Artifact containing the AppImage: nextcloud-appimage-pr-9487.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
GitHub Copilot doesn't seem to be aware that emoji shortcodes in labels are rendered on GitHub. Right now these labels use those shortcodes, this can be verified from the public REST endpoint https://api.github.com/repos/nextcloud/desktop/labels?per_page=100 (e.g. I've seen this action creating a new label because of that and was confused at why the colour was different and why there suddenly were two labels with the same display name :D |
|



No description provided.