Skip to content

fix: show paused status when account has no sync sources - #9473

Merged
Rello merged 5 commits into
masterfrom
codex/fix-account-status-sync-issue
Feb 20, 2026
Merged

fix: show paused status when account has no sync sources#9473
Rello merged 5 commits into
masterfrom
codex/fix-account-status-sync-issue

Conversation

@Rello

@Rello Rello commented Feb 19, 2026

Copy link
Copy Markdown
Collaborator

Motivation

  • The tray window incorrectly displayed “All synced!” for a connected account that had no configured sync folders and no enabled VFS/File Provider, while the tray icon correctly showed the pause state.

Description

  • Add hasConfiguredSyncSource() helper to detect whether the current account has any configured sync folder or an enabled File Provider/VFS domain (guarded by BUILD_FILE_PROVIDER_MODULE).
  • Update setSyncStateToConnectedState() to show “Sync paused” with the pause icon when the account is connected but has no configured sync source instead of reporting “All synced!”.
  • Restrict the initial sync-state evaluation in initSyncState() to only process folders that belong to the active account to avoid unrelated folders affecting the tray summary.
  • Modified file: src/gui/tray/syncstatussummary.cpp.

Testing

  • Attempted to build the macOS target with xcodebuild build -target NextcloudDev, but the command failed in this environment because xcodebuild is not available (bash: command not found: xcodebuild).
  • No other automated test runs were executed in this environment.

Codex Task

@Rello

Rello commented Feb 19, 2026

Copy link
Copy Markdown
Collaborator Author

Account is connected, but no folder sync nor VFS is enabled. the status is wrong

Bildschirmfoto 2026-02-19 um 08 45 38

@Rello Rello added this to the 33.0.0 milestone Feb 19, 2026
Comment thread src/gui/tray/syncstatussummary.cpp
Co-authored-by: Camila Ayres <[email protected]>
Signed-off-by: Rello <[email protected]>
Comment thread src/gui/tray/syncstatussummary.cpp Outdated
Co-authored-by: Camila Ayres <[email protected]>
Signed-off-by: Rello <[email protected]>

@nilsding nilsding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems better than displaying a successful sync in that edge case, thanks

Comment thread src/gui/tray/syncstatussummary.cpp Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-9473.zip

Digest: sha256:6d364a5c3e59c3fa6ce65d91cbd007dfb3ed66ead810c730f32c2d4592c8746e

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
3 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Rello
Rello merged commit 4d6526d into master Feb 20, 2026
21 of 24 checks passed
@Rello
Rello deleted the codex/fix-account-status-sync-issue branch February 20, 2026 18:15
@nilsding

Copy link
Copy Markdown
Member

/backport to stable-33.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants