Skip to content

feature: new settings UI - #9419

Merged
nilsding merged 5 commits into
masterfrom
feature/settingsV2
Feb 26, 2026
Merged

feature: new settings UI#9419
nilsding merged 5 commits into
masterfrom
feature/settingsV2

Conversation

@Rello

@Rello Rello commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

prototype for the new settings dialog

@Rello Rello self-assigned this Feb 3, 2026
@Rello

Rello commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator Author
Bildschirmfoto 2026-02-05 um 19 06 14 Bildschirmfoto 2026-02-05 um 19 06 02

@Rello Rello linked an issue Feb 5, 2026 that may be closed by this pull request
Settings UI #8651
Closed
@Rello Rello added this to the 33.0.0 milestone Feb 5, 2026
@Rello Rello moved this to 🏗️ In progress in 💻 Desktop Clients team Feb 5, 2026
@Rello Rello added the design Design, UI, UX, etc. label Feb 5, 2026
@Rello

Rello commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator Author
Bildschirmfoto 2026-02-26 um 09 20 59 Bildschirmfoto 2026-02-26 um 09 20 33

@Rello
Rello marked this pull request as ready for review February 26, 2026 08:22
@i2h3

i2h3 commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

Please squash this before merging. 🙈

@i2h3 i2h3 added feature: ☁️ GUI System tray icon and menu. 3. to review and removed 2. developing labels Feb 26, 2026
mgallien
mgallien requested changes Feb 26, 2026
View reviewed changes

@mgallien mgallien left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rebase removed too many items in MainWidnow.qml
need to fix

Comment thread src/gui/tray/MainWindow.qml
Comment thread src/gui/tray/MainWindow.qml
@mgallien
mgallien force-pushed the feature/settingsV2 branch 2 times, most recently from bb07bb2 to dad898d Compare February 26, 2026 11:17
@mgallien
mgallien self-requested a review February 26, 2026 11:17
@mgallien
mgallien force-pushed the feature/settingsV2 branch 2 times, most recently from 84cb08e to b6cbe21 Compare February 26, 2026 11:37
@mgallien

mgallien commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

Please squash this before merging. 🙈

done

nilsding
nilsding reviewed Feb 26, 2026
View reviewed changes
Comment thread src/gui/networksettings.ui Outdated
nilsding
nilsding reviewed Feb 26, 2026
View reviewed changes
Comment thread src/gui/settingsdialog.cpp Outdated
nilsding
nilsding reviewed Feb 26, 2026
View reviewed changes
Comment thread src/gui/folderstatusdelegate.cpp Outdated
i2h3
i2h3 approved these changes Feb 26, 2026
View reviewed changes

@i2h3 i2h3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through the code changes but I cannot comment on them due to my lack of experience with Qt and QML.

Rello
Rello commented Feb 26, 2026
View reviewed changes
Comment thread src/gui/settingsdialog.cpp Outdated
Rello and others added 5 commits February 26, 2026 21:22
@Rello @nilsding
feat: move settings navigation to left sidebar
58db9d7 
Signed-off-by: Rello <[email protected]>
@Rello @nilsding
Apply suggestion from @Rello
8db6e89 
Signed-off-by: Rello <[email protected]>
@Rello @nilsding
fix: border
e7e3adf 
Signed-off-by: Rello <[email protected]>
@Rello @nilsding
fix: Remove zorder for upload limit radio buttons
b849005 
Removed zorder properties for upload limit radio buttons.

Signed-off-by: Rello <[email protected]>
@nilsding
fix(settings): do not overlap warning message
269f279 
Signed-off-by: Jyrki Gadinger <[email protected]>
@nilsding

nilsding commented Feb 26, 2026

Copy link
Copy Markdown
Member

/backport to stable-33.0

@nilsding
nilsding enabled auto-merge February 26, 2026 20:24
@github-actions

github-actions Bot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-9419.zip

Digest: sha256:45edde7a440ac135b3410e0da89039862584b8f1a4f2b1fe085528e9af393a24

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding
nilsding merged commit 916a4b3 into master Feb 26, 2026
21 of 22 checks passed
@nilsding
nilsding deleted the feature/settingsV2 branch February 26, 2026 21:06
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Feb 26, 2026
@sonarqubecloud

sonarqubecloud Bot commented Feb 26, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
36.7% Coverage on New Code (required ≥ 80%)
76 New Code Smells (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien

mgallien commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

/backport to stable-33.0

1 similar comment
@nilsding

nilsding commented Feb 26, 2026

Copy link
Copy Markdown
Member

/backport to stable-33.0

@Floweb05

Floweb05 commented Feb 27, 2026

Copy link
Copy Markdown

Bildschirmfoto 2026-02-26 um 09 20 59 Bildschirmfoto 2026-02-26 um 09 20 33

look awesome, great work!

@Rello

Rello commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-33.0

@backportbot backportbot Bot mentioned this pull request Feb 27, 2026
Merged
@mgallien mgallien modified the milestones: 33.0.0, 34.0.0 Mar 12, 2026
@jancborchardt jancborchardt mentioned this pull request May 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsding nilsding nilsding left review comments
@mgallien mgallien mgallien approved these changes
@i2h3 i2h3 i2h3 approved these changes
@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio
@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

Assignees

@Rello Rello

Labels

3. to review design Design, UI, UX, etc. feature: ☁️ GUI System tray icon and menu.

Projects

None yet

Milestone

34.0.0

Development

Successfully merging this pull request may close these issues.

Settings UI

5 participants

@Rello @i2h3 @mgallien @nilsding @Floweb05