Skip to content

feat: client integration with server features - #9403

Merged
camilasan merged 22 commits into
masterfrom
feature/integration
Feb 18, 2026
Merged

feat: client integration with server features#9403
camilasan merged 22 commits into
masterfrom
feature/integration

Conversation

@camilasan

@camilasan camilasan commented Jan 31, 2026

Copy link
Copy Markdown
Member

Implements nextcloud/files-clients#86

  • screenshots

tbd

  • to do

    • get designer's input
    • filter by mime type
      • there are some glitches
    • test with files explorer/finder context menu
    • do not show file actions when there are none

@camilasan camilasan closed this Jan 31, 2026
@camilasan camilasan reopened this Jan 31, 2026
@camilasan camilasan mentioned this pull request Jan 31, 2026
8 tasks
@camilasan
camilasan force-pushed the feature/integration branch 6 times, most recently from 1e44251 to 039efde Compare January 31, 2026 21:19
@camilasan camilasan added this to the 33.0.0 milestone Feb 2, 2026
@camilasan
camilasan marked this pull request as ready for review February 2, 2026 19:02
@mgallien

mgallien commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

reviewing it

@nilsding nilsding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Some unit tests for at least the FileActionsModel and (if possible) Capabilities::fileActionsByMimeType would be really nice to have as well.

Comment thread src/gui/integration/declarativeuimodel.cpp Outdated
Comment thread src/gui/integration/declarativeuimodel.cpp Outdated
Comment thread src/gui/integration/declarativeuimodel.cpp Outdated
Comment thread src/gui/integration/declarativeuimodel.h Outdated
Comment thread src/gui/integration/fileactionsmodel.cpp Outdated
Comment thread src/gui/integration/FileActionsWindow.qml
Comment thread src/gui/tray/activitydata.cpp Outdated
Comment thread src/gui/CMakeLists.txt
Comment thread src/libsync/capabilities.cpp Outdated
Comment thread src/gui/integration/FileActionsWindow.qml Outdated
@camilasan
camilasan force-pushed the feature/integration branch 3 times, most recently from d6a05da to 5a24e0e Compare February 3, 2026 12:19
@Rello Rello moved this to 🏗️ In progress in 💻 Desktop Clients team Feb 5, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Comment thread src/gui/integration/fileactionsmodel.h Outdated
Comment thread src/gui/integration/fileactionsmodel.h Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Comment thread src/gui/integration/fileactionsmodel.h
Comment thread src/gui/integration/fileactionsmodel.h
- display response from request from file actions.

Signed-off-by: Camila Ayres <[email protected]>
- add helper function to match string to SimpleApiJob::Verb.
- filter and display file actions based on the file mimetype.
- adjust logic to get context menu by mimeType.
- create function to set file id and mime type.
- rename Endpoint to FileActions.

Signed-off-by: Camila Ayres <[email protected]>
- improve error handling.
- display a different icon for each mimetype.

Signed-off-by: Camila Ayres <[email protected]>
…n't have one.

- improve file actions window UI.

Signed-off-by: Camila Ayres <[email protected]>
…ements like url.

- add opacity mask and more spacing.
- implement hover for the file action buttons.
- fix logic to display error/success messages.
- improve text for error/success messages.

Signed-off-by: Camila Ayres <[email protected]>
The declarative ui in fact will be returned in the response from file actions.

Signed-off-by: Camila Ayres <[email protected]>
- use reference type in for loop.
- fix spaces and sizes in the file actions window.
- remove missing file from resources.

Signed-off-by: Camila Ayres <[email protected]>
- remove DeclarativeUi files.
- add return default value in switch.
- add const.

Signed-off-by: Camila Ayres <[email protected]>
- Removed unused fileas and variables.
- Add reference on non-trivial type.
- Add [[nodiscard]] to functions declaration.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan
camilasan merged commit fa78845 into master Feb 18, 2026
17 of 18 checks passed
@camilasan
camilasan deleted the feature/integration branch February 18, 2026 08:13
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Feb 18, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants