fix: Change destination encoding to percent encoding - #9334
Merged
Conversation
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9334.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Rello
marked this pull request as ready for review
January 21, 2026 07:57
Rello
requested review from
Aiiaiiio,
camilasan,
i2h3,
mgallien and
nilsding
as code owners
January 21, 2026 07:57
mgallien
approved these changes
Jan 21, 2026
fixes #9333 Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
mgallien
enabled auto-merge
January 22, 2026 09:14
mgallien
force-pushed
the
bugfix/encoding
branch
from
January 22, 2026 09:14
918b9c4 to
771b07b
Compare
|
nilsding
added a commit
that referenced
this pull request
Mar 10, 2026
sabre/dav does not seem to approve of percent-encoded base URLs (e.g. `http%3A//nextcloud.local/...`), it will then consider them as absolute paths and fail. --> adapt fix from #9334 to only encode the remote path, as sabre parses those paths just fine. Resolves: #9582 Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
added a commit
that referenced
this pull request
Mar 11, 2026
sabre/dav does not seem to approve of percent-encoded base URLs (e.g. `http%3A//nextcloud.local/...`), it will then consider them as absolute paths and fail. --> adapt fix from #9334 to only encode the remote path, as sabre parses those paths just fine. Resolves: #9582 Signed-off-by: Jyrki Gadinger <[email protected]>
backportbot Bot
pushed a commit
that referenced
this pull request
Mar 11, 2026
sabre/dav does not seem to approve of percent-encoded base URLs (e.g. `http%3A//nextcloud.local/...`), it will then consider them as absolute paths and fail. --> adapt fix from #9334 to only encode the remote path, as sabre parses those paths just fine. Resolves: #9582 Signed-off-by: Jyrki Gadinger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9333
Percent-encoded the chunked upload Destination header so literal % sequences in remote paths are preserved, preventing chunked upload failures for special-character folders