fix: try to avoid displaying duplicate server notifications in activity list #8782
Conversation
nilsding
force-pushed
the
bugfix/6624/duplicate-notifications-in-activity-list
branch
from
5460d47 to
8e34d4c
Compare
nilsding
requested review from
Aiiaiiio,
camilasan,
i2h3 and
mgallien
as code owners
nilsding
changed the title
| } | ||
|
|
||
| for (const auto &activity : std::as_const(toNotifyList)) { | ||
| if (toNotifyList.size() == 1) { |
There was a problem hiding this comment.
I don't understand this part. Why is it different if we have only 1 activity to notify about versus more?
There was a problem hiding this comment.
User::showDesktopNotification(const Activity &activity) will add the notification to the activity list and also display a system notification, whereas User::showDesktopNotification(const ActivityList &activityList) only ends up adding those to the activity list. It's weird.
also get rid of an unused list Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Jyrki Gadinger <[email protected]>
This change might clean up notifications that have already been dismissed from the web ui as well. Resolves #6624 Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
force-pushed
the
bugfix/6624/duplicate-notifications-in-activity-list
branch
from
8e34d4c to
b9f1467
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8782.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
mgallien
deleted the
bugfix/6624/duplicate-notifications-in-activity-list
branch
|
/backport to stable-3.17 |
Resolves #6624
includes some cleanup in UserModel and ActivityListModel