Fix nautilus integration emblems #8769
Conversation
Aiiaiiio
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
there is an issue with the REUSE check
you need to add the new file in https://github.com/nextcloud/desktop/blob/master/REUSE.toml#L27
also maybe you may want to remove the no longer used files with combined states
|
this PR fixes a general issue so we need to merge it for now. |
Of course. I'll create new assets :) |
Signed-off-by: Tamás Bari <[email protected]>
…nd emblem The issue is that the folder/file emblems appeared very small if they are shared, because the shared version of the emblems are not square and Nautilus will scale them to fit. Signed-off-by: Tamás Bari <[email protected]>
Signed-off-by: Tamás Bari <[email protected]>
Switched to wildcard for the SVGs instead of listing all of them one-by-one. Signed-off-by: Tamás Bari <[email protected]>
mgallien
force-pushed
the
fix/nautilus-integration-emblems
branch
from
cfc2c11 to
a77969f
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8769.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fixes: #5133.
To make the emblems appear larger, I simply re-scaled them.
Furthermore, now the shared state of a file is indicated by a second emblem instead of a combined one.
See change on image (current version to the left, new version to the right):