Skip to content

l10n: Correct text string - #3205

Closed
Valdnet wants to merge 2 commits into
masterfrom
Valdnet-patch-2
Closed

l10n: Correct text string#3205
Valdnet wants to merge 2 commits into
masterfrom
Valdnet-patch-2

Conversation

@Valdnet

@Valdnet Valdnet commented Apr 26, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Valdnet [email protected]

@Valdnet
Valdnet requested a review from FlexW April 26, 2021 08:27
@nextcloud-desktop-bot

Copy link
Copy Markdown

AppImage file: Nextcloud-PR-3205-cfb02644e06bad10541c8a48d8d6a3950fe1f583-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@er-vin er-vin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I see the point. Those strings are overwritten during the app lifetime anyway. They can just be ignored.

@er-vin

er-vin commented Apr 26, 2021

Copy link
Copy Markdown
Member

Clicked send too quickly...

Is it some tooling flagging them somehow? I wonder if that'd be enough to mark them as non translated strings instead. Semantically this would feel more correct then pushing people to translate something which doesn't need to be. :-)

@Valdnet

Valdnet commented Apr 26, 2021

Copy link
Copy Markdown
Contributor Author

Well, these strings are in Transifex and translators translate them.

@er-vin

er-vin commented Apr 26, 2021

Copy link
Copy Markdown
Member

Right, so the right fix would be instead to mark them as non-translated strings in Qt Designer, this way they'll stop being extracted. No need to drop useless strings on the translators.

@FlexW

FlexW commented Apr 26, 2021

Copy link
Copy Markdown

@er-vin The strings are not marked as translatable at the moment.

@er-vin

er-vin commented Apr 26, 2021 via email

Copy link
Copy Markdown
Member

@Valdnet

Valdnet commented Apr 26, 2021

Copy link
Copy Markdown
Contributor Author

In this case, I am closing PR, but I hope that the problem will be discussed until the end 馃槈.

@FlexW

FlexW commented Apr 27, 2021

Copy link
Copy Markdown

@Valdnet I created an issue for that #3221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants