Skip to content

fix(macOS): use tag to pass menu command to Finder extension. - #10528

Merged
camilasan merged 2 commits into
masterfrom
bugfix/finder-menu
Aug 4, 2026
Merged

fix(macOS): use tag to pass menu command to Finder extension.#10528
camilasan merged 2 commits into
masterfrom
bugfix/finder-menu

Conversation

@camilasan

@camilasan camilasan commented Aug 3, 2026

Copy link
Copy Markdown
Member

Summary

There is a bug in macOS where it does not use/copy over the representedObject of a menu item. So we have to use tag instead. The tag was removed with xpc rewrite.

Checklist

AI (if applicable)

@camilasan camilasan added this to the 34.0.1 milestone Aug 3, 2026
@camilasan

Copy link
Copy Markdown
Member Author

/backport to stable-34.0.0

@camilasan
camilasan force-pushed the bugfix/finder-menu branch from e0b219b to a747173 Compare August 3, 2026 14:10
@camilasan
camilasan marked this pull request as ready for review August 3, 2026 14:10
@camilasan camilasan changed the title fix(macOS): carry FinderSync menu command via tag, not identifier. fix(macOS): carry FinderSync menu command via tag. Aug 3, 2026
@camilasan
camilasan force-pushed the bugfix/finder-menu branch from a747173 to c1ef1db Compare August 3, 2026 14:13
@camilasan camilasan changed the title fix(macOS): carry FinderSync menu command via tag. fix(macOS): pass FinderSync menu command via tag. Aug 3, 2026
@camilasan
camilasan force-pushed the bugfix/finder-menu branch from c1ef1db to 4672b25 Compare August 3, 2026 14:31
@camilasan camilasan changed the title fix(macOS): pass FinderSync menu command via tag. fix(macOS): use tag to pass menu command to Finder extension. Aug 3, 2026
@camilasan

Copy link
Copy Markdown
Member Author

The tests failing here are passing locally for me.

Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Camila Ayres <[email protected]>
Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
camilasan force-pushed the bugfix/finder-menu branch from 4672b25 to 048fd93 Compare August 4, 2026 07:02
@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10528.zip

Digest: sha256:61d52549abbe575d49f379d295dfc360d23a7d92a055e9019caf7e34bc586708

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan
camilasan merged commit e04fa44 into master Aug 4, 2026
23 checks passed
@camilasan
camilasan deleted the bugfix/finder-menu branch August 4, 2026 08:11
@backportbot

backportbot Bot commented Aug 4, 2026

Copy link
Copy Markdown

The backport to stable-34.0.0 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-34.0.0
git pull origin stable-34.0.0

# Create the new backport branch
git checkout -b backport/10528/stable-34.0.0

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 198645af 048fd936

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/10528/stable-34.0.0

Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/10528/stable-34.0.0')
fatal: not a valid object name: 'origin/stable-34.0.0'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@camilasan

Copy link
Copy Markdown
Member Author

/backport to stable-34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants