fix(macOS): use tag to pass menu command to Finder extension. - #10528
Conversation
|
/backport to stable-34.0.0 |
e0b219b to
a747173
Compare
a747173 to
c1ef1db
Compare
c1ef1db to
4672b25
Compare
|
The tests failing here are passing locally for me. |
Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Camila Ayres <[email protected]>
Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Camila Ayres <[email protected]>
4672b25 to
048fd93
Compare
|
|
Artifact containing the AppImage: nextcloud-appimage-pr-10528.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
The backport to # Switch to the target branch and update it
git checkout stable-34.0.0
git pull origin stable-34.0.0
# Create the new backport branch
git checkout -b backport/10528/stable-34.0.0
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 198645af 048fd936
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/10528/stable-34.0.0Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/10528/stable-34.0.0') Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable-34.0 |



Summary
There is a bug in macOS where it does not use/copy over the representedObject of a menu item. So we have to use tag instead. The tag was removed with xpc rewrite.
Checklist
AI (if applicable)