fix(discovery): move file lock state off the GUI thread. - #10500
Merged
Conversation
camilasan
requested review from
claucambra,
i2h3,
mgallien and
nilsding
as code owners
July 30, 2026 21:48
Member
Author
|
/backport to stable-34.0 |
camilasan
force-pushed
the
bugfix/10464/isFileLocked
branch
2 times, most recently
from
July 30, 2026 22:01
8661b79 to
8d09cf7
Compare
camilasan
changed the title
8 tasks
8 tasks
claucambra
reviewed
Jul 31, 2026
Fix for #10464. isFileLocked opened files synchronously on the GUI thread during discovery. A blocking open froze the UI and, through the shell extension, Explorer too. Compute the lock state on the local listing worker and carry it in LocalInfo, so handleExcluded reads a precomputed flag. Skip symlinks, virtual placeholders and directories. Assisted-by: Claude Code:claude-opus-4-8 Signed-off-by: Camila Ayres <[email protected]>
camilasan
force-pushed
the
bugfix/10464/isFileLocked
branch
from
July 31, 2026 11:37
ff09903 to
00e9972
Compare
nilsding
reviewed
Jul 31, 2026
Signed-off-by: Camila Ayres <[email protected]>
camilasan
force-pushed
the
bugfix/10464/isFileLocked
branch
from
July 31, 2026 12:02
00e9972 to
c163e46
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10500.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
claucambra
approved these changes
Jul 31, 2026
nilsding
approved these changes
Jul 31, 2026
nilsding
enabled auto-merge
July 31, 2026 12:23
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
#10464
Summary
isFileLocked opened files synchronously on the GUI thread during discovery. A blocking open froze the UI and, through the shell extension, Explorer too. Compute the lock state on the local listing worker and carry it in LocalInfo, so handleExcluded reads a precomputed flag. Skip symlinks, virtual placeholders and directories.
Checklist
AI (if applicable)