Skip to content

[stable-34.0] fix(propagateupload): ensure file size stays the same for new uploads - #10494

Merged
Rello merged 2 commits into
stable-34.0from
backport/9823/stable-34.0
Jul 30, 2026
Merged

[stable-34.0] fix(propagateupload): ensure file size stays the same for new uploads#10494
Rello merged 2 commits into
stable-34.0from
backport/9823/stable-34.0

Conversation

@backportbot

@backportbot backportbot Bot commented Jul 30, 2026

Copy link
Copy Markdown

Backport of PR #9823

nilsding added 2 commits July 30, 2026 15:23
It is possible that the sync engine discovers a file with a small enough
file size to use the old V1 upload propagator.  This is fine unless the file
size is still growing between discovery and propagation; should the file grow
large enough before propagation starts the propagator job may attempts to
upload the file in chunks using the old (removed with Nextcloud 30) chunking
mechanism.  Since Nextcloud 30 this no longer works as it only has support for
V2 upload chunking (PropagateUploadFileNG), resulting in broken partial
uploads while the client believes everything got uploaded.

The PropagateUploadFileCommon job already checks whether the file is
different, however relying on just the mtime is not enough for new files.

Signed-off-by: Jyrki Gadinger <[email protected]>
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10494.zip

Digest: sha256:23df1b83e2a43b0f9459b0450dfe6c0cf5207501a8970d1e4406773f903be8c6

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Rello
Rello merged commit 158a262 into stable-34.0 Jul 30, 2026
20 of 21 checks passed
@Rello
Rello deleted the backport/9823/stable-34.0 branch July 30, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants