[stable-34.0] perf(activity): cache singleton pointers and avoid string concat in hot path - #10358
Merged
Merged
Conversation
nilsding
approved these changes
Jul 13, 2026
…in hot path - FolderMan::instance(): make it an inline accessor returning the static pointer, removing the out-of-line call overhead at every use site without adding any local caching or extra complexity. - ActivityListModel::convertLinkToActionButton: move the reply icon URL construction inside the isReplyIconApplicable branch and bake the trailing slash into the string literal so the path is a single immutable QString instead of two QString::operator+ allocations. Signed-off-by: Qoole <[email protected]>
nilsding
force-pushed
the
backport/9997/stable-34.0
branch
from
July 13, 2026 11:31
d49ab93 to
e96a98f
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10358.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #9997