Skip to content

[stable-34.0] Feature/governance labels integration - #10353

Merged
mgallien merged 26 commits into
stable-34.0from
backport/10100/stable-34.0
Jul 13, 2026
Merged

[stable-34.0] Feature/governance labels integration#10353
mgallien merged 26 commits into
stable-34.0from
backport/10100/stable-34.0

Conversation

@backportbot

@backportbot backportbot Bot commented Jul 13, 2026

Copy link
Copy Markdown

Backport of PR #10100

mgallien added 26 commits July 13, 2026 08:41
will enable to share type definitions in all real jobs

Signed-off-by: Matthieu Gallien <[email protected]>
also improve the available properties for the job parameters

Signed-off-by: Matthieu Gallien <[email protected]>
finish implementing most of the code needed to send requests to the
governance API

will need further work to see how to read the replies and make something
usefull

Signed-off-by: Matthieu Gallien <[email protected]>
should enable us to test the requests one by one and ensure we decode
properly the replies

Signed-off-by: Matthieu Gallien <[email protected]>
we explicitely define which roles need to be used

Signed-off-by: Matthieu Gallien <[email protected]>
Restyle GovernanceLabelsDialog to match the design system used by
AccountWizardWindow and its sub-components in wizard/qml/:

- Set explicit wizard palette and background on the ApplicationWindow
  for full light/dark mode support
- Replace stock ComboBox, Button and DialogButtonBox with WizardComboBox
  and WizardButton for consistent Nextcloud branding
- Add bold dialog title heading, update margins to 24 px, fix spacing
- Wrap all label strings in qsTr() and apply wizard text colors
- Fix window title typo ("Applys labels" → "Apply labels")
- Add WizardComboBox.qml, a reusable styled combo box following the
  WizardButton/WizardTextField component pattern

Signed-off-by: Matthieu Gallien <[email protected]>
Assisted-by: ClaudeCode:claude-sonnet-4-6
should make it easier and more predictable to use from QML

Signed-off-by: Matthieu Gallien <[email protected]>
the model is responsible to provide data to the UI and manage the
set of selected labels by taking UI input and delegating the
modifications via emitted signals

Signed-off-by: Matthieu Gallien <[email protected]>
the item in the combobox have the ability to show if they are selected
or not

refresh state as soon as one label is selected

select a selected one will remove it

select an unselected one will apply it

selecting none should remove all labels

Signed-off-by: Matthieu Gallien <[email protected]>
we need to request available and selected labels in a proper sequence or
we cannot guarantee that the model state is correct

Signed-off-by: Matthieu Gallien <[email protected]>
Add mdiSecurity and mdiFileClockOutline SVG icons from Material Design
Authors (Apache-2.0) to the theme folder and display them inline before
the Sensitivity and Retention section labels in GovernanceLabelsDialog.

Assisted-by: ClaudeCode:claude-sonnet-4-6
Signed-off-by: Matthieu Gallien <[email protected]>
we need to request available and selected labels in a proper sequence or
we cannot guarantee that the model state is correct

Signed-off-by: Matthieu Gallien <[email protected]>
the reply from OCS API calls of governance app have small changes
needing an update of our code to be aligned and up to date

Signed-off-by: Matthieu Gallien <[email protected]>
@backportbot
backportbot Bot requested a review from camilasan as a code owner July 13, 2026 08:42
@backportbot
backportbot Bot requested a review from nilsding July 13, 2026 08:42
@backportbot
backportbot Bot requested review from i2h3 and mgallien as code owners July 13, 2026 08:42
@backportbot
backportbot Bot requested a review from nilsding as a code owner July 13, 2026 08:42
@backportbot backportbot Bot added feature: ☁️ GUI System tray icon and menu. 3. to review labels Jul 13, 2026
@backportbot backportbot Bot added this to the 34.0.0 milestone Jul 13, 2026
@mgallien
mgallien enabled auto-merge July 13, 2026 08:47
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10353.zip

Digest: sha256:cea40310aefc9d744eb1b2abb9bbe133dc8b8d05cd6b3ee2737917bcdac7b801

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
mgallien merged commit 7636c8d into stable-34.0 Jul 13, 2026
19 checks passed
@mgallien
mgallien deleted the backport/10100/stable-34.0 branch July 13, 2026 09:33
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
56.8% Coverage on New Code (required ≥ 80%)
95 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review feature: ☁️ GUI System tray icon and menu.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant