[stable-34.0] Feature/governance labels integration - #10353
Merged
Conversation
will enable to share type definitions in all real jobs Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
also improve the available properties for the job parameters Signed-off-by: Matthieu Gallien <[email protected]>
finish implementing most of the code needed to send requests to the governance API will need further work to see how to read the replies and make something usefull Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
should enable us to test the requests one by one and ensure we decode properly the replies Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
we explicitely define which roles need to be used Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Restyle GovernanceLabelsDialog to match the design system used by
AccountWizardWindow and its sub-components in wizard/qml/:
- Set explicit wizard palette and background on the ApplicationWindow
for full light/dark mode support
- Replace stock ComboBox, Button and DialogButtonBox with WizardComboBox
and WizardButton for consistent Nextcloud branding
- Add bold dialog title heading, update margins to 24 px, fix spacing
- Wrap all label strings in qsTr() and apply wizard text colors
- Fix window title typo ("Applys labels" → "Apply labels")
- Add WizardComboBox.qml, a reusable styled combo box following the
WizardButton/WizardTextField component pattern
Signed-off-by: Matthieu Gallien <[email protected]>
Assisted-by: ClaudeCode:claude-sonnet-4-6
Signed-off-by: Matthieu Gallien <[email protected]>
should make it easier and more predictable to use from QML Signed-off-by: Matthieu Gallien <[email protected]>
the model is responsible to provide data to the UI and manage the set of selected labels by taking UI input and delegating the modifications via emitted signals Signed-off-by: Matthieu Gallien <[email protected]>
the item in the combobox have the ability to show if they are selected or not refresh state as soon as one label is selected select a selected one will remove it select an unselected one will apply it selecting none should remove all labels Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
we need to request available and selected labels in a proper sequence or we cannot guarantee that the model state is correct Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Add mdiSecurity and mdiFileClockOutline SVG icons from Material Design Authors (Apache-2.0) to the theme folder and display them inline before the Sensitivity and Retention section labels in GovernanceLabelsDialog. Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Matthieu Gallien <[email protected]>
we need to request available and selected labels in a proper sequence or we cannot guarantee that the model state is correct Signed-off-by: Matthieu Gallien <[email protected]>
the reply from OCS API calls of governance app have small changes needing an update of our code to be aligned and up to date Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
approved these changes
Jul 13, 2026
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10353.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Backport of PR #10100