fix(exclude): avoid trying to read patterns from file when reading failed - #10335
Merged
Conversation
Member
Author
|
/backport to stable-34.0 please |
Member
Author
|
/backport to stable-33.0 please |
…iled Signed-off-by: Jyrki Gadinger <[email protected]>
…eating placeholder files Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
force-pushed
the
bugfix/10301/win32-cfapi-syncexclude
branch
from
July 10, 2026 05:36
0b16fd6 to
bf0ac8d
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10335.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
mgallien
approved these changes
Jul 10, 2026
This was referenced Jul 10, 2026
Merged
This was
linked to
issues
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
#10301
Summary
The Windows on-demand VFS creates placeholder files while the folders are being navigated to. This worked fine until a folder was opened which contains a folder-specific exclude patterns file: the sync engine would keep trying to read from the placeholder file forever.
--> resolve it by catching read errors in csync_exclude, and mark the exclude pattern file to be downloaded with the next sync while creating placeholders
Checklist
AI (if applicable)