Skip to content

[stable-34.0] fix(cmd,csync): don't silently ignore a missing --exclude file - #10291

Merged
mgallien merged 1 commit into
stable-34.0from
backport/10283/stable-34.0
Jul 2, 2026
Merged

[stable-34.0] fix(cmd,csync): don't silently ignore a missing --exclude file#10291
mgallien merged 1 commit into
stable-34.0from
backport/10283/stable-34.0

Conversation

@backportbot

@backportbot backportbot Bot commented Jul 2, 2026

Copy link
Copy Markdown

Backport of PR #10283

nextcloudcmd's ExcludedFiles::reloadExcludeFiles() dropped a
registered exclude file from the list without any warning when
QFile::exists() returned false, and still reported success. A
mistyped or unresolved --exclude path (e.g. a relative path that
resolves differently under cron than interactively) therefore made
nextcloudcmd sync everything with zero exclusions and no diagnostic
in the log.

- csync_exclude.cpp: log a qWarning when a registered exclude file
  can't be found, instead of silently erasing it.
- cmd.cpp: fail fast with qFatal when a user-supplied --exclude path
  doesn't exist, instead of only discovering it deep inside
  reloadExcludeFiles() with no way to distinguish "path is wrong"
  from "path was never wrong to begin with".

Fixes #4621

Signed-off-by: mosandlt <[email protected]>
@backportbot
backportbot Bot requested a review from camilasan as a code owner July 2, 2026 14:00
@backportbot
backportbot Bot requested a review from mgallien July 2, 2026 14:00
@backportbot
backportbot Bot requested review from i2h3, mgallien and nilsding as code owners July 2, 2026 14:00
@backportbot backportbot Bot added this to the 34.0.0 milestone Jul 2, 2026
@mgallien
mgallien enabled auto-merge July 2, 2026 14:02
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10291.zip

Digest: sha256:2f01d63cfb07ace1279d7621dab545ed4c5314a4baa2b8ebb78972fc8557a68d

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
mgallien merged commit 6e32823 into stable-34.0 Jul 2, 2026
17 checks passed
@mgallien
mgallien deleted the backport/10283/stable-34.0 branch July 2, 2026 14:19
@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants