Skip to content

[stable-34.0] Remove QtWebEngine - #10278

Merged
i2h3 merged 1 commit into
stable-34.0from
backport/10092/stable-34.0
Jul 1, 2026
Merged

[stable-34.0] Remove QtWebEngine#10278
i2h3 merged 1 commit into
stable-34.0from
backport/10092/stable-34.0

Conversation

@backportbot

@backportbot backportbot Bot commented Jul 1, 2026

Copy link
Copy Markdown

Backport of PR #10092

Drop the legacy embedded login flow (Flow v1 / WebViewFlow) and every
piece of build, packaging, and signing infrastructure that existed to
support it. The modern OAuth flow (Flow2, used by Nextcloud server
>= 16.0.0) already drives login through the system browser and remains
the only authentication path.

User-visible consequence: Nextcloud servers older than 16.0.0, and any
server advertising the legacy globalscale.desktoplogin=1 capability,
can no longer be added through an in-app embedded browser. Modern
servers are unaffected.

Changes:
- delete src/gui/wizard/webview{,page}.{h,cpp,ui,ui.license}
- drop BUILD_WITH_WEBENGINE option, find_package calls, and
  target_link_libraries entries from CMake; drop the cmakedefine in
  config.h.in
- remove DetermineAuthTypeJob's WebViewFlow enum value and the
  third (OldFlow) capability probe; the job now only runs the GET and
  PROPFIND probes
- remove ConfigFile::forceLoginV2 / setForceLoginV2 and the
  forceLoginV2 settings key
- drop the useFlow2 boolean machinery: WebFlowCredentialsDialog now
  always hosts Flow2AuthWidget, and OwncloudWizard / OwncloudSetupPage
  no longer thread a useFlow2 flag
- drop Page_WebView, WebViewPage, the welcomepage WebEngine branch
  (Create Account now always opens the system browser), and related
  #ifdef WITH_WEBENGINE blocks
- remove --without-webengine flag and buildWithWebEngine craft option
  from mac-crafter
- remove signQtWebEngineProcessApp helper from mac-crafter's Signer
- remove the WiX/MSI rule that stripped Qt6WebEngineCore.pdb
- remove qt5.qtwebengine (and the now-dead isARM helper) from the Nix
  flake

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
@backportbot
backportbot Bot requested a review from camilasan as a code owner July 1, 2026 12:09
@backportbot
backportbot Bot requested a review from i2h3 July 1, 2026 12:09
@backportbot
backportbot Bot requested review from i2h3, mgallien and nilsding as code owners July 1, 2026 12:09
@backportbot backportbot Bot added os: 🍎 macOS Apple macOS, formerly also known as OS X os: 🚪 Windows os: 🐧 Linux 3. to review Performance 🚀 dependencies Pull requests that update a dependency file labels Jul 1, 2026
@backportbot backportbot Bot added this to the 34.0.0 milestone Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10278.zip

Digest: sha256:378d26fb08618f1fd56930835c44dd01ad0596315aabebb5979fd6e875a1bc0c

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@i2h3
i2h3 merged commit 821394e into stable-34.0 Jul 1, 2026
18 of 19 checks passed
@i2h3
i2h3 deleted the backport/10092/stable-34.0 branch July 1, 2026 12:48
@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
3 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review dependencies Pull requests that update a dependency file os: 🍎 macOS Apple macOS, formerly also known as OS X os: 🚪 Windows os: 🐧 Linux Performance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant