[stable-34.0] Remove QtWebEngine - #10278
Merged
Merged
Conversation
Drop the legacy embedded login flow (Flow v1 / WebViewFlow) and every
piece of build, packaging, and signing infrastructure that existed to
support it. The modern OAuth flow (Flow2, used by Nextcloud server
>= 16.0.0) already drives login through the system browser and remains
the only authentication path.
User-visible consequence: Nextcloud servers older than 16.0.0, and any
server advertising the legacy globalscale.desktoplogin=1 capability,
can no longer be added through an in-app embedded browser. Modern
servers are unaffected.
Changes:
- delete src/gui/wizard/webview{,page}.{h,cpp,ui,ui.license}
- drop BUILD_WITH_WEBENGINE option, find_package calls, and
target_link_libraries entries from CMake; drop the cmakedefine in
config.h.in
- remove DetermineAuthTypeJob's WebViewFlow enum value and the
third (OldFlow) capability probe; the job now only runs the GET and
PROPFIND probes
- remove ConfigFile::forceLoginV2 / setForceLoginV2 and the
forceLoginV2 settings key
- drop the useFlow2 boolean machinery: WebFlowCredentialsDialog now
always hosts Flow2AuthWidget, and OwncloudWizard / OwncloudSetupPage
no longer thread a useFlow2 flag
- drop Page_WebView, WebViewPage, the welcomepage WebEngine branch
(Create Account now always opens the system browser), and related
#ifdef WITH_WEBENGINE blocks
- remove --without-webengine flag and buildWithWebEngine craft option
from mac-crafter
- remove signQtWebEngineProcessApp helper from mac-crafter's Signer
- remove the WiX/MSI rule that stripped Qt6WebEngineCore.pdb
- remove qt5.qtwebengine (and the now-dead isARM helper) from the Nix
flake
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10278.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Backport of PR #10092